Repository navigation
Conversation
JJenkx
marked this pull request as ready for review
October 14, 2026 01:54
JJenkx
force-pushed
the
fix/cached-compact-resource-plans
branch
from
October 14, 2026 16:12
2610662 to
e650bf1
Compare
JJenkx
force-pushed
the
fix/cached-compact-resource-plans
branch
3 times, most recently
from
October 15, 2026 10:56
2b84f7d to
51a159c
Compare
JJenkx
force-pushed
the
fix/cached-compact-resource-plans
branch
from
October 15, 2026 10:59
51a159c to
2098259
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk shader-memory reads now respect
CaptureProfiled()before updating read totals, matching the scalar read path. This branch also checks that cached plans rebuild their compact evaluation data and that cached bulk reads report only the requested words across a page boundary, including repeated captures.Two commits on main
8856f180ca0b5605574842666ffbc8b0bb69cc4d; head2098259a7813566243f83a1458321b44d054cdb5. Main already includes the compact-plan implementation from boykopovar#1193, so this refresh retains only the profiling correction and additional regressions. Shader cache format 36 is unchanged.Validation: Linux x86-64 Release build of full runtime libraries and the selected test executables. With
APS5_VERIFY_SRT_COMPACT=1, all 20 selected cache, shader-memory and prepared-shader/graphics CTest cases passed on both Radeon RX 6650 XT (RADV Mesa 26.2.4) and lavapipe, with zero skips. The negative controls and restored-source reruns were completed on basea08de6827; the complete build and both positive 20-case sets were repeated after the rebase onto8856f180c. Conventions and whitespace checks pass.The unchanged regression sources detect both deliberate production faults: removing cache-load
CompactPlanfails with “the cached plan lost compact evaluation data”; marking entire cached pages as read fails with “an unaligned cached run recorded unrelated words”. Test executables were rebuilt against each faulty implementation, then the production sources were restored and rebuilt. The exact-span case runs throughagc_shader_bindless; the cache round-trip case runs throughagc_shader_disk_cache.The local validation build differs from this public head only by a private SPIRV-Tools teardown repair in the submodule. That dependency change is excluded from this PR; these results do not independently validate the official dependency pin. No current Windows/full-suite or title FPS result is claimed.